Naming Guidelines
PFT1701: Use US English
severity: 1
All identifiers (such as types, type members, parameters and variables) should be named using words from the American English language.
- Choose easily readable, preferably grammatically correct names. For example,
HorizontalAlignment
is more readable thanAlignmentHorizontal
. - Favor readability over brevity. The property name
CanScrollHorizontally
is better thanScrollableX
(an obscure reference to the X-axis). - Avoid using names that conflict with keywords of widely used programming languages.
PFT1702: Use proper casing for language elements
severity: 1
Language element | Casing | Example |
---|---|---|
Namespace | Pascal | System.Drawing |
Type parameter | Pascal | TView |
Interface | Pascal | IBusinessService |
Class, struct | Pascal | AppDomain |
Enum | Pascal | ErrorLevel |
Enum member | Pascal | FatalError |
Resource key | Pascal | SaveButtonTooltipText |
Constant field | Pascal | MaximumItems |
Private static readonly field | Pascal | RedValue |
Private field | Camel | listItem |
Non-private field | Pascal | MainPanel |
Property | Pascal | BackColor |
Event | Pascal | Click |
Method | Pascal | ToString |
Local function | Pascal | FormatText |
Parameter | Camel | typeName |
Tuple element names | Pascal | (string First, string Last) name = ("John", "Doe"); var name = (First: "John", Last: "Doe"); (string First, string Last) GetName() => ("John", "Doe"); |
Variables declared using tuple syntax | Camel | (string first, string last) = ("John", "Doe"); var (first, last) = ("John", "Doe"); |
Local variable | Camel | listOfValues |
Note: in case of ambiguity, the rule higher in the table wins.
PFT1704: Don't include numbers in variables, parameters and type members
severity: 3
In most cases they are a lazy excuse for not defining a clear and intention-revealing name.
PFT1705: Don't prefix fields
severity: 1
For example, don't use g_
or s_
to distinguish static from non-static fields. A method in which it is difficult to distinguish local variables from member fields is generally too big. Examples of incorrect identifier names are: _currentUser
, mUserName
, m_loginTime
.
PFT1707: Name members, parameters and variables according to their meaning and not their type
severity: 2
- Use functional names. For example,
GetLength
is a better name thanGetInt
. - Don't use terms like
Enum
,Class
orStruct
in a name. - Identifiers that refer to a collection type should have plural names.
PFT1708: Name types using nouns, noun phrases or adjective phrases
severity: 2
For example, the name IComponent uses a descriptive noun, ICustomAttributeProvider uses a noun phrase and IPersistable uses an adjective.
Bad examples include SearchExamination
(a page to search for examinations), Common
(does not end with a noun, and does not explain its purpose) and SiteSecurity
(although the name is technically okay, it does not say anything about its purpose).
Don't include terms like Utility
or Helper
in classes. Classes with names like that are usually static classes and are introduced without considering object-oriented principles (see also PFT1008).
PFT1709: Name generic type parameters with descriptive names
severity: 2
- Always prefix type parameter names with the letter
T
. - Always use a descriptive name unless a single-letter name is completely self-explanatory and a longer name would not add value. Use the single letter
T
as the type parameter in that case. - Consider indicating constraints placed on a type parameter in the name of the parameter. For example, a parameter constrained to
ISession
may be calledTSession
.
PFT1710: Don't repeat the name of a class or enumeration in its members
severity: 1
class Employee
{
// Wrong!
static GetEmployee() {...}
DeleteEmployee() {...}
// Right
static Get() {...}
Delete() {...}
// Also correct.
AddNewJob() {...}
RegisterForMeeting() {...}
}
PFT1711: Name members similarly to members of related .NET Framework classes
severity: 3
.NET developers are already accustomed to the naming patterns the framework uses, so following this same pattern helps them find their way in your classes as well. For instance, if you define a class that behaves like a collection, provide members like Add
, Remove
and Count
instead of AddItem
, Delete
or NumberOfItems
.
PFT1712: Avoid short names or names that can be mistaken for other names
severity: 1
Although technically correct, statements like the following can be confusing:
bool b001 = (lo == l0) ? (I1 == 11) : (lOl != 101);
PFT1715: Properly name properties
severity: 2
- Name properties with nouns, noun phrases, or occasionally adjective phrases.
- Name boolean properties with an affirmative phrase. E.g.
CanSeek
instead ofCannotSeek
. - Consider prefixing boolean properties with
Is
,Has
,Can
,Allows
, orSupports
. - Consider giving a property the same name as its type. When you have a property that is strongly typed to an enumeration, the name of the property can be the same as the name of the enumeration. For example, if you have an enumeration named
CacheLevel
, a property that returns one of its values can also be namedCacheLevel
.
PFT1720: Name methods and local functions using verbs or verb-object pairs
severity: 2
Name a method or local function using a verb like Show
or a verb-object pair such as ShowDialog
. A good name should give a hint on the what of a member, and if possible, the why.
Also, don't include And
in the name of a method or local function. That implies that it is doing more than one thing, which violates the Single Responsibility Principle explained in PFT1115.
PFT1725: Name namespaces using names, layers, verbs and features
severity: 3
For instance, the following namespaces are good examples of that guideline.
Feature.Marketing
Client.Feature.PageContent
Foundation.Serialization
NHibernate.Extensibility
Microsoft.ServiceModel.WebApi
Microsoft.VisualStudio.Debugging
FluentAssertion.Primitives
Note: Never allow namespaces to contain the name of a type, but a noun in its plural form (e.g. Collections
) is usually OK.
PFT1735: Use a verb or verb phrase to name an event
severity: 2
Name events with a verb or a verb phrase. For example: Click
, Deleted
, Closing
, Minimizing
, and Arriving
. For example, the declaration of the Search
event may look like this:
public event EventHandler<SearchArgs> Search;
PFT1737: Use -ing
and -ed
to express pre-events and post-events
severity: 3
For example, a close event that is raised before a window is closed would be called Closing
, and one that is raised after the window is closed would be called Closed
. Don't use Before
or After
prefixes or suffixes to indicate pre and post events.
Suppose you want to define events related to the deletion of an object. Avoid defining the Deleting
and Deleted
events as BeginDelete
and EndDelete
. Define those events as follows:
Deleting
: Occurs just before the object is getting deletedDelete
: Occurs when the object needs to be deleted by the event handler.Deleted
: Occurs when the object is already deleted.
PFT1738: Prefix an event handler with "On"
severity: 3
It is good practice to prefix the method that handles an event with "On". For example, a method that handles its own Closing
event should be named OnClosing
. And a method that handles the Click
event of its okButton
field should be named OkButtonOnClick
.
PFT1739: Use an underscore for irrelevant lambda parameters
severity: 3
If you use a lambda expression (for instance, to subscribe to an event) and the actual parameters of the event are irrelevant, use the following convention to make that explicit:
button.Click += (_, __) => HandleClick();
PFT1745: Group extension methods in a class suffixed with Extensions
severity: 3
If the name of an extension method conflicts with another member or extension method, you must prefix the call with the class name. Having them in a dedicated class with the Extensions
suffix improves readability.
PFT1755: Postfix asynchronous methods with Async
or TaskAsync
severity: 2
The general convention for methods and local functions that return Task
or Task<TResult>
is to postfix them with Async
. But if such a method already exists, use TaskAsync
instead.